Make Typed::Result sealed
#58
Conversation
We only ever want there to be two inheritors of `Typed::Result`, `Success` and `Failure`. We can express this in Sorbet with the `sealed!` helper. In order to use this, we must move the definitions of `Success` and `Failure` into the same file as `Result`. See https://sorbet.org/docs/sealed for more info.
|
@iMacTia Do you see any issues with moving |
|
Not a huge fan of the "everything in one file" approach, but the advantages are interesting and probably worth it! If we really want to be thorough, we could release this as v2.0, but maybe that's a bit of a stretch. |
|
Happy to also run some sanity checks against our monolith using this branch or |
|
| Not a huge fan of the "everything in one file" approach Agreed, it was pretty weird to recombine everything. But I think the extra information we can give Sorbet about exhaustiveness is worth it. I'll go ahead and merge this in and test our primary repos off of main as well. I'll wait til #56 and #57 are done to cut a new |
|
Finally got around to checkout |
Sorbet has the ability to mark a module/class as
sealed, limiting inheritors to only the file where the abstract class was defined. Since we only wantTyped::SuccessandTyped::Failurechildren, markResultas sealed. This is technically a breaking change, as downstream code could have inherited fromResultbefore this commit.This also aids in flow typing. The newly added case type check test will fail on main right now because Sorbet can't exhaustively say all subtypes of
Resultwere handled. With this change, we're able to demonstrate that the absurd case can never be ran.Finally, since we no longer need to autoload
success.rbandfailure.rb, I will remove Zeitwerk in favor of manual requires for now.